This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
refactor per module checks #9039
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iarna
force-pushed
the
iarna/refactor-per-module-checks
branch
from
4ce9320
to
51eb3f6
Compare
There was some weirdness going on where, depending on your local setup during release, you could get unexpected results during build (specifically, the version on the tarball and zip corresponded to your global npm's version) I went ahead and also made it so the npm pack is also done by the version getting released, to avoid any possible issues with 2.x vs 3.x PR-URL: #9012
This includes a bugfix, kapouer/marked-man#4 , which Fixes #8984 PR-URL: #8990
|
Lots of stuff, so you maaaybe want another set of eyeballs, too? LGTM, though. I say 🐑 if your tests pass :) |
This does a few things: 1. It fixes the calls to npm-install-checks– we were passing a read-package-tree node, and it wants package.json data. 2. This moves checks to be at "install" time (resolveWithNewModule), so they happen earlier. 3. Arguments passed in from the command line are checked even earlier. This is where "don't install yourself" checks are done. PR-URL: #9039 Fixes: #8637 Fixes: #8921
iarna
force-pushed
the
iarna/refactor-per-module-checks
branch
from
51eb3f6
to
e395d60
Compare
iarna
added a commit
that referenced
this pull request
Jul 24, 2015
This does a few things: 1. It fixes the calls to npm-install-checks– we were passing a read-package-tree node, and it wants package.json data. 2. This moves checks to be at "install" time (resolveWithNewModule), so they happen earlier. 3. Arguments passed in from the command line are checked even earlier. This is where "don't install yourself" checks are done. PR-URL: #9039 Fixes: #8637 Fixes: #8921
|
This was released w/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This in turn fixes #8637 and #8921
It also fixes a here-to-unknown engine checking bug (that is to say, it wasn't checking them– if it had been, it would have been inappropriately exploding <.<).