This repository has been archived by the owner on Aug 11, 2022. It is now read-only.
lifecycle: add /d and /s to cmd.exe #9245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/d disables cmd.exe AutoRuns feature,
where registry entry points to the
script that will be executed when cmd.exe
starts. Surprisingly a lot of users
hase "CD \" or similar command there
which causes lifecycle scripts to fail,
since relative path to the script no longer
works (and package.json has no way to deduce
absolute path)
/s enables handling of quotes, so that you
can have "C:\Program Files\Node\node.exe" quoted
in your script. Node's child_process.exec()
is doing the same. We prevent additional quoting
by libuv already by setting uv_spawn() flag
UV_PROCESS_WINDOWS_VERBATIM_ARGUMENTS.
If those flags are not set there is no way
package.json can reliably tell us to run "node"
executable with a relative script path:
"scripts": {
"install": "node scripts/install.js"
}
Without /d "node" invocation may end up
in a random directory as a result of
the AutoRuns command.
Fixes:
npm#8751
npm#7333
sass/node-sass#1027
sass/node-sass#1012
sass/node-sass#659
sass/node-sass#603
othiym23
pushed a commit
that referenced
this pull request
Aug 21, 2015
/d disables cmd.exe AutoRuns feature, where registry entry points to the
script that will be executed when cmd.exe starts. Surprisingly a lot of
users hase "CD \" or similar command there which causes lifecycle
scripts to fail, since relative path to the script no longer works (and
package.json has no way to deduce absolute path)
/s enables handling of quotes, so that you can have "C:\Program
Files\Node\node.exe" quoted in your script. Node's child_process.exec()
is doing the same. We prevent additional quoting by libuv already by
setting uv_spawn() flag UV_PROCESS_WINDOWS_VERBATIM_ARGUMENTS.
If those flags are not set there is no way package.json can reliably
tell us to run "node" executable with a relative script path:
"scripts": {
"install": "node scripts/install.js"
}
Without /d "node" invocation may end up in a random directory as a
result of the AutoRuns command.
Fixes: #8751
Fixes: #7333
PR-URL: #9245
iarna
pushed a commit
that referenced
this pull request
Aug 21, 2015
/d disables cmd.exe AutoRuns feature, where registry entry points to the
script that will be executed when cmd.exe starts. Surprisingly a lot of
users hase "CD \" or similar command there which causes lifecycle
scripts to fail, since relative path to the script no longer works (and
package.json has no way to deduce absolute path)
/s enables handling of quotes, so that you can have "C:\Program
Files\Node\node.exe" quoted in your script. Node's child_process.exec()
is doing the same. We prevent additional quoting by libuv already by
setting uv_spawn() flag UV_PROCESS_WINDOWS_VERBATIM_ARGUMENTS.
If those flags are not set there is no way package.json can reliably
tell us to run "node" executable with a relative script path:
"scripts": {
"install": "node scripts/install.js"
}
Without /d "node" invocation may end up in a random directory as a
result of the AutoRuns command.
Fixes: #8751
Fixes: #7333
PR-URL: #9245
|
Thanks. I think traditional unit testing is not well suited for integration issues like this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/ddisablescmd.exeAutoRuns feature, where registry entry points to the script that will be executed when cmd.exe starts. Surprisingly a lot of users haveCD \or similar command there which causes lifecycle scripts to fail, since relative path to the script no longer works (andpackage.jsonhas no way to deduce absolute path)/s enables handling of quotes, so that you can have "C:\Program Files\Node\node.exe" quoted in your script. Node's
child_process.exec()is doing the same. We prevent additional quoting by libuv already by settinguv_spawn()flagUV_PROCESS_WINDOWS_VERBATIM_ARGUMENTS.If those flags are not set there is no way package.json can reliably tell us to run "node" executable with a relative script path:
Without /d "node" invocation may end up in a random directory as a result of the AutoRuns command.
Fixes:
#8751
#7333
sass/node-sass#1027
sass/node-sass#1012
sass/node-sass#659
sass/node-sass#603