This repository has been archived by the owner on Jan 4, 2020. It is now read-only.
Do not let update-notifier errors crash the bin #132
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found problem testing 3.7.0 with
update-notifier
file permissions. This is somewhat of an uglyhackfix to handle cases of running thenpme
bin between sudo/root and non-root users.~/.config/configstore/update-notifier-npme.json
file) when runningupdate-notifier
update-notifier
on prescribed installation (sudo npm i -g npme --unsafe
) by using a hidden alias of theinstall
command for thepostinstall
scriptupdate-notifier
update message to saysudo npm i -g
instead ofnpm i -g
The goal of item 2 is to check for updates when running the bin with valid non-autoinstall command (by decorating each command
builder
function) or with invalid/missing command (via custom yargs failure handler and strict mode).I have tested this on an existing instance that already had npmo/npme installed, but I still need to test it against a fresh install instance. Will do that via
next
tag after merging this.