-
Notifications
You must be signed in to change notification settings - Fork 6
implemented a CLI for generating and deleting tokens #4
Conversation
Otherwise, this is looking good. |
Anything goes for these currently, I figured it would be nice for folks to be able to pick an email and username; this way if they have their CI server, as an example, publishing modules the info int the website can reference the CI server. |
Given points |
@nexdrew okay, I think this is ready for review again; I'm going to start playing with getting two auth strategies installed in my local npmo-docker-compose setup. |
Would be nice to accept I vote 🐑 |
Oh, bin name in the README examples needs to be updated |
Will the use of hashes in Redis affect other auth strategies? I guess if they attempt to grab a key of the incorrect type, they'll just error out and This will be fine as long as other strategies are not attempting to iterate over all keys without expecting different types. |
Might be nice to include a timestamp in the Redis value for when the token was created. |
Might also be nice to sort the tokens before displaying the list, but at least the tokens are ordered consistently. |
Sorry, I can think of several things that "might be nice" but are completely unnecessary. Feel free to ignore those comments. |
I think they probably should be, I was being lazy; I'll patch this.
Might as well? I'll add this.
We're already mixing and matching the two in the wild (our earliest strategies use serialized JSON, our newer strategies have moved to hashes). I think we're cool. |
implemented a CLI for generating and deleting tokens
There's now a bin for generating and deleting tokens:
reviewers: @nexdrew