rethrow git pathspec errors from git operations on hosted services #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukekarrys
changed the title
wraithgar
approved these changes
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rethrows git pathspec errors early since there is no point in retrying them.
In
_resolvedFromHostedthe benefit is that resolving doesn't need to be attempted again.In
_cloneHostedprior to this change, retrying a missing pathspec would change the error to something likefatal: destination path '/Users/lukekarrys/.npm/_cacache/tmp/git-clone-e421e02b/.git' already exists and is not an empty directory.which was obscuring the actual error.With this change, this is what the error looks like in the cli:
Old
New
Ref: npm/cli#3149