Skip to content
This repository has been archived by the owner on May 4, 2024. It is now read-only.

test: remove duplicate variable #53

Closed
wants to merge 1 commit into from
Closed

test: remove duplicate variable #53

wants to merge 1 commit into from

Conversation

kenany
Copy link
Contributor

@kenany kenany commented Oct 2, 2015

No description provided.

@othiym23 othiym23 self-assigned this Oct 30, 2015
@othiym23
Copy link
Contributor

Not only is this a good find, this is a strong signal that we should probably standardify read-package-json, because a linter totes would have caught this. ❤️, @kenany!

@kenany
Copy link
Contributor Author

kenany commented Nov 1, 2015

@othiym23 Oooh that would be nice! Looks like standard is already in use but the version this repo uses doesn't catch it. I'll send a PR to update to standard@^5.3.1 so that we would get this next time:

$ npm t

> read-package-json@2.0.1 test /home/kenan/Code/forks/read-package-json
> standard && tap test/*.js

standard: Use JavaScript Standard Style (https://github.com/feross/standard) 
  /home/kenan/Code/forks/read-package-json/test/readmes.js:9:5: "expect" is already defined
npm ERR! Test failed.  See above for more details.

@kenany kenany mentioned this pull request Nov 1, 2015
@othiym23
Copy link
Contributor

othiym23 commented Nov 5, 2015

Landed as 32c86e5. Thanks, Kenan!

@othiym23 othiym23 closed this Nov 5, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants