Skip to content
This repository has been archived by the owner on May 4, 2024. It is now read-only.

deps: replace json-parse-helpfulerror with parse-json #72

Merged
merged 2 commits into from
Aug 15, 2017

Conversation

zkat
Copy link
Contributor

@zkat zkat commented Aug 3, 2017

I've replaced this with json-parse-better-errors, which is MIt-licensed. (previously, this was switching to parse-json, but that inlined jju, so no, we can't use it).

@coveralls
Copy link

coveralls commented Aug 3, 2017

Coverage Status

Coverage remained the same at 70.87% when pulling 1ecef48 on zkat/parse-json-replacement into e44f800 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.87% when pulling 1ecef48 on zkat/parse-json-replacement into e44f800 on master.

@isaacs
Copy link
Contributor

isaacs commented Aug 3, 2017

As a profiteering capitalist overlord of "Open Source", this LGTM. 👍

@iarna
Copy link
Contributor

iarna commented Aug 3, 2017

parse-json inlines jju and thus still has WTFPL licencsed code:

https://github.com/sindresorhus/parse-json/blob/master/vendor/parse.js#L4

@MylesBorins
Copy link

MylesBorins commented Aug 15, 2017

I wonder if that invalidates the MIT license of the parse-json... this kind of ambiguity probably makes the PCOoOSS's (profiteering corporate overlords of open source software) nervous

¯\_(ツ)_/¯

Looks like you could lift the code from https://github.com/npm/node-fetch-npm/pull/6/files to fix this... or make a 📦 or something 😇

Thanks for the hard work!!!

@zkat zkat force-pushed the zkat/parse-json-replacement branch from 1ecef48 to 8e8e61a Compare August 15, 2017 23:26
@zkat
Copy link
Contributor Author

zkat commented Aug 15, 2017

@MylesBorins done

@coveralls
Copy link

coveralls commented Aug 15, 2017

Coverage Status

Coverage remained the same at 70.87% when pulling 8e8e61a on zkat/parse-json-replacement into e44f800 on master.

Copy link
Contributor

@iarna iarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@iarna iarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, tests are failing, but after they're fixed, LGTM.

jju, used by json-parse-helpfulerror, is WTFPL-licensed, and someone
decided this was no longer ok. So we have to replace it. Feh.
@zkat zkat force-pushed the zkat/parse-json-replacement branch from 8e8e61a to e74e0bd Compare August 15, 2017 23:33
@coveralls
Copy link

coveralls commented Aug 15, 2017

Coverage Status

Coverage remained the same at 70.87% when pulling e74e0bd on zkat/parse-json-replacement into e44f800 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.87% when pulling e74e0bd on zkat/parse-json-replacement into e44f800 on master.

@zkat zkat merged commit 04bef29 into master Aug 15, 2017
@zkat zkat deleted the zkat/parse-json-replacement branch August 15, 2017 23:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants