-
Notifications
You must be signed in to change notification settings - Fork 81
deps: replace json-parse-helpfulerror with parse-json #72
Conversation
1 similar comment
As a profiteering capitalist overlord of "Open Source", this LGTM. 👍 |
https://github.com/sindresorhus/parse-json/blob/master/vendor/parse.js#L4 |
I wonder if that invalidates the MIT license of the ¯\_(ツ)_/¯ Looks like you could lift the code from https://github.com/npm/node-fetch-npm/pull/6/files to fix this... or make a 📦 or something 😇 Thanks for the hard work!!! |
1ecef48
to
8e8e61a
Compare
@MylesBorins done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, tests are failing, but after they're fixed, LGTM.
jju, used by json-parse-helpfulerror, is WTFPL-licensed, and someone decided this was no longer ok. So we have to replace it. Feh.
8e8e61a
to
e74e0bd
Compare
I've replaced this with
json-parse-better-errors
, which is MIt-licensed. (previously, this was switching toparse-json
, but that inlinedjju
, so no, we can't use it).