Fixes for shipping dist/ files and running prepare in CI #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukekarrys
changed the title
|
If dependencies need to be installed for |
|
I don't think so, but check my math here:
Currently |
|
Ok so What confused me is that To prevent it having to run more than once, you run Out of scope for this PR, but that seems clunky all things considered. |
wraithgar
approved these changes
Nov 20, 2023
Merged
lukekarrys
pushed a commit
that referenced
this pull request
Nov 27, 2023
🤖 I have created a release *beep* *boop* --- ## [3.0.1](v3.0.0...v3.0.1) (2023-11-20) ### Bug Fixes * [`22cb8dc`](22cb8dc) [#84](#84) only ship dist files (@lukekarrys) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I published
3.0.0from my local environment but in doing so accidentally published it with many more files than necessary.This fixes the issue so
3.0.1can be published with only the necessary dist files.This also fixes the publish step so dependencies are installed before
prepareis called.