Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: backport regex change from 8.0.1 #19

Closed
wants to merge 1 commit into from
Closed

fix: backport regex change from 8.0.1 #19

wants to merge 1 commit into from

Conversation

nlf
Copy link
Contributor

@nlf nlf commented Apr 7, 2021

backport of #17 so we can apply it to npm 6

References

nlf added a commit that referenced this pull request Apr 7, 2021
@nlf
fix: backport regex change from 8.0.1
b30dfdb 
PR-URL: #19
Credit: @nlf
Close: #19
Reviewed-by: @wraithgar
@nlf nlf closed this Apr 7, 2021
@G-Rath
Copy link

G-Rath commented Apr 14, 2021 •
edited

@nif is there any chance of getting this applied to v7 (of ssri, not npm 😅).

I'm looking at cacache@13 which depends on ssri@^7.0.0 - this package is pulled in by terser-webpack-plugin which in turn is pull directly in by webpack, so I think landing this on v7 would save a lot of people some pain.

(I've opened #20 based on this backport, targeted at the v7 branch)

@G-Rath G-Rath mentioned this pull request Apr 14, 2021
Closed
@wraithgar wraithgar deleted the nlf/backport-regex-fix branch June 10, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wraithgar wraithgar wraithgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nlf @G-Rath @wraithgar