npm login should output npm-notice headers returned from registry
#411
Comments
|
@lukekarrys assigning to you as I know you are deep in the woods with logging at the moment. Can provide more context for this in standup today. |
darcyclarke
changed the title
npm-notice headers returned from registrynpm login should output npm-notice headers returned from registry
lukekarrys
added a commit
to npm/cli
that referenced
this issue
Nov 30, 2021
This decouples the log file writing from the terminal logging. We now open an append only file at the start of the process and stream logs to it. We still only display the log file message in timing mode or if there is an error, but the file is still written regardless. All logging now goes through `proc-log` and his is the first step to removing `npmlog`. For now `npmlog` is still used for the terminal logging but with a shim in front of it to make it easier to test and use in conjunction with `proc-log`. Ref: npm/statusboard#366 This also refactors many of the tests to always use an explicit `t.testdir` for their cache since the file is opened on each `new Npm()`. Tests are also refactored to use more of `MockNpm` with behavior to add config items and load `npm` if necessary. A new fixture `mockGlobals` was also added to make much of this for ergonomic. Ref: npm/statusboard#410 Closes npm/statusboard#411 Closes npm/statusboard#367
lukekarrys
added a commit
to npm/cli
that referenced
this issue
Dec 1, 2021
This decouples the log file writing from the terminal logging. We now open an append only file at the start of the process and stream logs to it. We still only display the log file message in timing mode or if there is an error, but the file is still written regardless. All logging now goes through `proc-log` and this is the first step to removing `npmlog`. For now `npmlog` is still used for the terminal logging but with a shim in front of it to make it easier to test and use in conjunction with `proc-log`. Ref: npm/statusboard#366 This also refactors many of the tests to always use an explicit `t.testdir` for their cache since the file is opened on each `new Npm()`. Tests are also refactored to use more of `MockNpm` with behavior to add config items and load `npm` if necessary. A new fixture `mockGlobals` was also added to make much of this more ergonomic. Ref: npm/statusboard#410 Closes npm/statusboard#411 Closes npm/statusboard#367
lukekarrys
added a commit
to npm/cli
that referenced
this issue
Dec 2, 2021
This decouples the log file writing from the terminal logging. We now open an append only file at the start of the process and stream logs to it. We still only display the log file message in timing mode or if there is an error, but the file is still written regardless. All logging now goes through `proc-log` and this is the first step to removing `npmlog`. For now `npmlog` is still used for the terminal logging but with a shim in front of it to make it easier to test and use in conjunction with `proc-log`. Ref: npm/statusboard#366 This also refactors many of the tests to always use an explicit `t.testdir` for their cache since the file is opened on each `new Npm()`. Tests are also refactored to use more of `MockNpm` with behavior to add config items and load `npm` if necessary. A new fixture `mockGlobals` was also added to make much of this more ergonomic. Ref: npm/statusboard#410 Closes npm/statusboard#411 Closes npm/statusboard#367 PR-URL: #4062 Credit: @lukekarrys Close: #4062 Reviewed-by: @wraithgar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
npm logindoesn't output thenpm-noticeresponse headers from the registry in>=7(works inv6). Notabluy,"We're not passing in the logging module tonpm-profileso it defaults to a silent logger."~ gar (ref. https://github.com/npm/npm-registry-fetch/blob/main/check-response.js#L7-L19)Expected behavior
You should see any
npm-noticelog that is passed back from the registry in the CLI when runningnpm login,npm profileetc.The text was updated successfully, but these errors were encountered: