Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config): display publishConfig information #417

Closed
2 tasks done
darcyclarke opened this issue Dec 7, 2021 · 0 comments
Closed
2 tasks done

feat(config): display publishConfig information #417

darcyclarke opened this issue Dec 7, 2021 · 0 comments

Comments

@darcyclarke
Copy link
Contributor

darcyclarke commented Dec 7, 2021 •
edited by lukekarrys
Loading

Summary

publishConfig can be defined in package.json & later used when running npm publish. Users may not be aware they have separate config defined for this operation making it confusing to debug or troubleshoot.

Exit Criteria

  • npm config list should log the publishConfig configuration if it exists in the cwd package.json (notably, there should be some meaningful distinction to explain & delineate this output similar to how we log user-level config)
  • ensure config/values are normalized & private information (ex. basic auth in a registry config) is redacted prior to logging

Example

; "publish" config from package.json
registry = "npm.pkg.github.com"
lukekarrys added a commit to npm/cli that referenced this issue Dec 9, 2021
@lukekarrys
feat: display publishConfig during config list
29d1e62 
Closes: npm/statusboard#417

If the file at `$NPM_CONFIG_Prefix/package.json` contains a
`publishConfig`, the key/value pairs will be printed along with the rest
of the output from `npm config ls`.
@lukekarrys lukekarrys mentioned this issue Dec 9, 2021
Merged
lukekarrys added a commit to npm/cli that referenced this issue Dec 9, 2021
@lukekarrys
feat: display publishConfig during config list
061e5f2 
Closes: npm/statusboard#417

If the file at `$NPM_CONFIG_PREFIX/package.json` contains a
`publishConfig`, the key/value pairs will be printed along with the rest
of the output from `npm config ls`.
@nlf nlf mentioned this issue Dec 9, 2021
Merged
@npm-robot npm-robot mentioned this issue Dec 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@darcyclarke