Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated workspace ci template to run correct tests #26

Merged
merged 1 commit into from
Jan 6, 2022
Merged

updated workspace ci template to run correct tests #26

merged 1 commit into from
Jan 6, 2022
+2 −2

Conversation

fritzy
Copy link
Contributor

@fritzy fritzy commented Jan 6, 2022

ci-workspace.yml files were setting the script execution to be hardcoded to the libnpmdiff workspace

@fritzy fritzy requested a review from a team as a code owner January 6, 2022 19:28
nlf
nlf suggested changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doh, was premature on clicking approve. need that commit title check to pass first

nlf
nlf approved these changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@fritzy fritzy merged commit 92764e1 into main Jan 6, 2022
@fritzy fritzy deleted the fritzy/fix-workspace-ci branch January 6, 2022 19:33
@github-actions github-actions bot mentioned this pull request Aug 25, 2022
Closed
@lukekarrys lukekarrys mentioned this pull request Aug 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlf nlf nlf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fritzy @nlf