Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: try to workaround old npm not being able to update in windows #36

Merged
merged 1 commit into from
Jan 31, 2022
Merged

fix: try to workaround old npm not being able to update in windows #36

merged 1 commit into from
Jan 31, 2022

Conversation

nlf
Copy link
Contributor

@nlf nlf commented Jan 27, 2022 •
edited
Loading

i also brought the ci-workspaces.yml in sync with the other workflows, but accounting for the workspace related changes. that probably should've been a separate commit but i got a little carried away..

@nlf nlf requested a review from a team as a code owner January 27, 2022 22:53
@nlf nlf force-pushed the nlf/workaround-windows-npm-bug branch 20 times, most recently from ea04198 to d0884a1 Compare January 28, 2022 19:20
@nlf nlf force-pushed the nlf/workaround-windows-npm-bug branch from d0884a1 to ac22d90 Compare January 28, 2022 19:26
wraithgar
wraithgar approved these changes Jan 31, 2022
View reviewed changes
Copy link
Member

@wraithgar wraithgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but we should probably have @fritzy sign off just in case those workspace ci files used ./bin/npm-cli.js for a reason

fritzy
fritzy approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@fritzy fritzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was no specific reason the workspaces ci was out of date. LGTM

@nlf nlf merged commit 194c434 into main Jan 31, 2022
@nlf nlf deleted the nlf/workaround-windows-npm-bug branch January 31, 2022 23:34
@nlf nlf mentioned this pull request Feb 1, 2022
Closed
2 tasks
dr-js added a commit to dr-js/dr-dev that referenced this pull request Feb 9, 2022
@dr-js
FIX: ci: npm@6+win32 bypass
d792fc4 
actions/setup-node#411
npm/cli#4341
npm/template-oss#36
dr-js added a commit to dr-js/dr-js that referenced this pull request Feb 11, 2022
@dr-js
FIX: ci: npm@6+win32 bypass
3649ec9 
actions/setup-node#411
npm/cli#4341
npm/template-oss#36
@github-actions github-actions bot mentioned this pull request Aug 25, 2022
Closed
@lukekarrys lukekarrys mentioned this pull request Aug 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wraithgar wraithgar wraithgar approved these changes

@fritzy fritzy fritzy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nlf @wraithgar @fritzy