fix: update a few release nits after trying it on the cli #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukekarrys
force-pushed
the
lk/release-updates
branch
2 times, most recently
from
c224c7c
to
7331d16
Compare
wraithgar
reviewed
Sep 1, 2022
wraithgar
approved these changes
Sep 1, 2022
- Correctly link workspace dep changelog entry to release even when release component is different than the package name - Update changelog entry also when rewriting workspaces deps - Clone repo during release process with `fetch-depth: 0` so we can have full commit history to build `AUTHORS` files - Removes `preversion`, `postversion`, and `prepublishOnly` scripts now that all tagging happens via `release-please` - Correctly version root when going from prerelease -> release Closes #178
lukekarrys
force-pushed
the
lk/release-updates
branch
from
7331d16
to
a26705f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
release component is different than the package name
fetch-depth: 0so we can havefull commit history to build
AUTHORSfilespreversion,postversion, andprepublishOnlyscripts nowthat all tagging happens via
release-pleaseCloses #178