Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release 4.21.0 #385

Merged
merged 1 commit into from
Dec 1, 2023
Merged

chore: release 4.21.0 #385

merged 1 commit into from
Dec 1, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 28, 2023

🤖 I have created a release beep boop

4.21.0 (2023-12-01)

Features

Bug Fixes


This PR was generated with Release Please. See documentation.

Copy link
Contributor Author

github-actions bot commented Nov 28, 2023

Release Manager

Release workflow run: https://github.com/npm/template-oss/actions/runs/7064640037

Release Checklist for v4.21.0

  • 1. Approve this PR

    gh pr review 385 -R npm/template-oss --approve
  • 2. Merge release PR 🚨 Merging this will auto publish 🚨

    gh pr merge 385 -R npm/template-oss --squash
  • 3. Check For Release Tags

    Release Please will run on the just pushed release commit and create GitHub releases and tags for each package.

    gh run watch -R npm/template-oss $(gh run list -R npm/template-oss -w release -b main -L 1 --json databaseId -q ".[0].databaseId")

@github-actions github-actions bot force-pushed the release-please--branches--main branch 5 times, most recently from 19c35bb to 23b06e1 Compare November 30, 2023 22:26
lukekarrys added a commit that referenced this pull request Dec 1, 2023
- fix: pin release-please version

There is a tradeoff with our usage of release-please. We are using some
`release-please` classes that we import directly from files like `const
{ ManifestPlugin } = require('release-please/build/src/plugin.js')`. Due
to how load bearing our release process is for us, I think it is best to
always pin to an exact version and use dependabot PRs to review all
`release-please` changes.

- chore: update release please mocks and snapshots

This PR also updates mocks and snapshots. I was not expecting this to
need to be updated but they failed in #385. It's possible that the mock
recording or the usage of these mocks inside release-please is
non-deterministic. I will keep an eye on these tests and refactor in the
future if they turn out to be flaky.
@github-actions github-actions bot force-pushed the release-please--branches--main branch from 23b06e1 to ec4479e Compare December 1, 2023 20:05
@github-actions github-actions bot force-pushed the release-please--branches--main branch from ec4479e to f8bb856 Compare December 1, 2023 20:06
@lukekarrys lukekarrys merged commit d13658b into main Dec 1, 2023
14 checks passed
@lukekarrys lukekarrys deleted the release-please--branches--main branch December 1, 2023 20:13
Copy link
Contributor Author

github-actions bot commented Dec 1, 2023

🤖 Release is at https://github.com/npm/template-oss/releases/tag/v4.21.0 🌻

Copy link
Contributor Author

github-actions bot commented Dec 1, 2023

Release Workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant