Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not collapse chores for now #392

Merged
merged 1 commit into from
Dec 5, 2023
Merged

fix: do not collapse chores for now #392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/content/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,6 @@ module.exports = {
{ type: 'fix', section: 'Bug Fixes', hidden: false, collapse: false },
{ type: 'docs', section: 'Documentation', hidden: false, collapse: false },
{ type: 'deps', section: 'Dependencies', hidden: false, collapse: false },
{ type: 'chore', section: 'Chores', hidden: false, collapse: true },
{ type: 'chore', section: 'Chores', hidden: false, collapse: false },
],
}
2 changes: 2 additions & 0 deletions lib/release/changelog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ class Changelog {
#getEntries (type) {
const section = this.#sections[type]
const entries = this.#entries[type].map(list)
// Ignoring coverage until we use this again
/* istanbul ignore next */
if (section?.collapse) {
entries.unshift('<details><summary>Commits</summary>\n')
entries.push('\n</details>')
Expand Down
2 changes: 1 addition & 1 deletion release-please-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"type": "chore",
"section": "Chores",
"hidden": false,
"collapse": true
"collapse": false
}
],
"packages": {
Expand Down
6 changes: 3 additions & 3 deletions tap-snapshots/test/apply/source-snapshots.js.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1390,7 +1390,7 @@ release-please-config.json
"type": "chore",
"section": "Chores",
"hidden": false,
"collapse": true
"collapse": false
}
],
"prerelease-type": "pre",
Expand Down Expand Up @@ -3050,7 +3050,7 @@ release-please-config.json
"type": "chore",
"section": "Chores",
"hidden": false,
"collapse": true
"collapse": false
}
],
"prerelease-type": "pre",
Expand Down Expand Up @@ -4427,7 +4427,7 @@ release-please-config.json
"type": "chore",
"section": "Chores",
"hidden": false,
"collapse": true
"collapse": false
}
],
"prerelease-type": "pre",
Expand Down
40 changes: 19 additions & 21 deletions tap-snapshots/test/release/release-please-cases-chore-commit.js.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,15 @@ Object {
---


<details><summary>2016.0.2-pre</summary>
<details><summary>2017.0.3-pre</summary>

## [2016.0.2-pre](https://github.com/npm/npm-cli-release-please/compare/v2016.0.1-pre...v2016.0.2-pre) (2023-12-04)
## [2017.0.3-pre](https://github.com/npm/npm-cli-release-please/compare/v2017.0.2-pre...v2017.0.3-pre) (2023-12-05)

### Chores

<details><summary>Commits</summary>

* [\`d690bcb\`](https://github.com/npm/npm-cli-release-please/commit/d690bcb622f954314086bc333cd56fa4d2b59897) this is a chore (@lukekarrys)
* [\`38acd0f\`](https://github.com/npm/npm-cli-release-please/commit/38acd0f850907c357e51caa56faa42526ace49d9) update template-oss (@lukekarrys)
* [\`f936a4b\`](https://github.com/npm/npm-cli-release-please/commit/f936a4be5f739048163b8346568f8bc49b7b53f9) this is a chore (@lukekarrys)

</details>
</details>
Expand All @@ -35,40 +34,39 @@ Object {
"labels": Array [
"autorelease: pending",
],
"number": 264,
"sha": "675ff2fa3a03500ce5748e38d05c003d80943e43",
"title": "chore: release 2016.0.2-pre",
"number": 268,
"sha": "9e96e7aa386e69fd38783b037402d2ffd64fb5fc",
"title": "chore: release 2017.0.3-pre",
}
`

exports[`test/release/release-please.js TAP cases chore commit > releases chore commit 1`] = `
Array [
Object {
"draft": false,
"id": 132552731,
"major": 2016,
"id": 132694534,
"major": 2017,
"minor": 0,
"name": "v2016.0.2-pre",
"name": "v2017.0.3-pre",
"notes": String(
## [2016.0.2-pre](https://github.com/npm/npm-cli-release-please/compare/v2016.0.1-pre...v2016.0.2-pre) (2023-12-04)
## [2017.0.3-pre](https://github.com/npm/npm-cli-release-please/compare/v2017.0.2-pre...v2017.0.3-pre) (2023-12-05)

### Chores

Commits

* [\`d690bcb\`](https://github.com/npm/npm-cli-release-please/commit/d690bcb622f954314086bc333cd56fa4d2b59897) this is a chore (@lukekarrys)
* [\`38acd0f\`](https://github.com/npm/npm-cli-release-please/commit/38acd0f850907c357e51caa56faa42526ace49d9) update template-oss (@lukekarrys)
* [\`f936a4b\`](https://github.com/npm/npm-cli-release-please/commit/f936a4be5f739048163b8346568f8bc49b7b53f9) this is a chore (@lukekarrys)
),
"patch": 2,
"patch": 3,
"path": ".",
"pkgName": "npm-cli-release-please",
"prNumber": 264,
"publishTag": "prerelease-2016",
"sha": "eaa230680541215efd72568054f187e8cebdd2a5",
"tagName": "v2016.0.2-pre",
"uploadUrl": "https://uploads.github.com/repos/npm/npm-cli-release-please/releases/132552731/assets{?name,label}",
"url": "https://github.com/npm/npm-cli-release-please/releases/tag/v2016.0.2-pre",
"version": "2016.0.2-pre",
"prNumber": 268,
"publishTag": "prerelease-2017",
"sha": "13b89ef2a76c624b3ebccda40ee817c4112744fc",
"tagName": "v2017.0.3-pre",
"uploadUrl": "https://uploads.github.com/repos/npm/npm-cli-release-please/releases/132694534/assets{?name,label}",
"url": "https://github.com/npm/npm-cli-release-please/releases/tag/v2017.0.3-pre",
"version": "2017.0.3-pre",
},
]
`
Loading