feat: scale modules by unpackedSize, closes #132
#211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
broofa
changed the title
unpackedSize, fix #132unpackedSize, closes #132
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
fontsizebased onunpackedSizeunpackedSizein the module pane (I've just slapped this in there for now so you can click on a module to see what it's actual size is. I'll figure out a better UI for this later.)This still needs work but you can play with it here.
For example, here's the
@parcel/utilsgraph, which is an interesting use case because@parcel/rusthas anunpackedSizeof 190MB.Currently the scaling factor varies as
log10(unpackedSize), so (roughly speaking)...This has the benefit that module size reliably corresponds to the
unpackedSize, regardless of graph. (I.e. we don't dynamically adjust scale based on, for example, the largest module in a graph.) But it does mean the scaling effect will be subtle for modules < 100KB. E.g. the effect is noticable in the the sshpk graph but doesn't exactly jump out at you.As usual, the express graph is a nice middle-ground in terms of complexity.
... which I'm okay with.
[Edit to add: It's worth noting
unpackedSizedata isn't available for [module | versions] published prior to Feb 2018.]