-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new ADRs in the "Proposed" state by default #61
Comments
Makes sense to me. Another place we've seen discussion take place is on the PR for the ADR itself, but even then there was a "Proposal" phase that gets committed and a follow up with the relevant points from the discussion. |
This is not as easy as I first thought. Some commands treat the status "Accepted" as a special case (e.g. Any conventions like this should be made "official": see #60 |
Out of curiosity, how many states are there for ADR assumed by this tool and what are they? Btw, I like the idea of having a Proposed state by default. All in all, I have seen Pending, Accepted, and Proposed. Are there more I'm not aware of? |
At the moment it’s free-form apart from apart from Accepted and Superceded
…On Thu, 17 Jan 2019 at 11:30, simkimsia ***@***.***> wrote:
Out of curiosity, how many states are there for ADR assumed by this tool?
Btw, I like the idea of having a Proposed state by default.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#61 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADbm49aUOuzMRHeWJXpJ7A6tiRE6fMSks5vEF7dgaJpZM4U8IU5>
.
|
May I suggest documenting this? I be happy to make a PR on the README |
This is a good idea. I guess for a use case example would be that all incoming work and their definitions for discussion for the next period/cycle of time would show proposed status which triggers discussion. Once the conversations are over, majority of the items becomes approved or rejected, any left over in proposed status shows up in the next period/cycle. |
Currently a new ADR is created in the Accepted state by default.
I suggest it is better to create new ADRs in the Proposed state. ADRs are meant to be discussed and agreed within a team. When team members are not all colocated, discussion can occur around or within the ADR document itself, until the team agree that the ADR is ready to be marked as Accepted.
This would also encourage teams to record proposed architecture decisions that are discussed and then rejected, along with the reasons for rejection.
The text was updated successfully, but these errors were encountered: