Retrieve all metrics in one POST instead of multiple GETs #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, we ran one GET request to the metrics endpoint per metric needed. After this commit, we POST an array of metrics to retrieve from the endpoint and get them all in one request. This is documented here: https://docs.puppet.com/puppetdb/4.4/api/metrics/v1/mbeans.html#bulk-retrieving-metrics As a side effect, we no longer url encode the metrics in the metrics hash that is stored in puppet code.
Prior to this commit, we attempted to post an empty array of metrics to the metrics endpoint. After this commit, we check to see if there are any metrics to gather before trying to gather them.
|
An observation. Does doing this with a POST this way obviate the need to carefully build lists of mbeans that exist on each version? When an mbean in the array doesn't exist the return array just has a null. How about we just compact the results to remove the entries with no data, and simplify the Puppet code to just always request all the possible metrics available from versions of PuppetDB we're interested in monitoring? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, we ran one GET request to the metrics
endpoint per metric needed.
After this commit, we POST an array of metrics to retrieve from
the endpoint and get them all in one request.
This is documented here:
https://docs.puppet.com/puppetdb/4.4/api/metrics/v1/mbeans.html#bulk-retrieving-metrics
As a side effect, we no longer url encode the metrics in the
metrics hash that is stored in puppet code.
This turns out to be about 10x faster. Around 5 seconds to retrieve PuppetDB metrics before the change and around 500 ms after the change.