Enable connecting to metrics without certificates #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npwalker
force-pushed
the
enable_connecting_to_metrics_endpoint_without_ssl
branch
from
2598d05
to
7e5edd3
Compare
|
@npwalker have you had a chance to test this yet? |
npwalker
force-pushed
the
enable_connecting_to_metrics_endpoint_without_ssl
branch
from
2eaaa5d
to
7497628
Compare
npwalker
changed the title
|
@reidmv I came to a different conclusion after testing. No need to use certs at all. |
npwalker
force-pushed
the
enable_connecting_to_metrics_endpoint_without_ssl
branch
from
7497628
to
b06f079
Compare
jarretlavallee
approved these changes
Jun 8, 2017
|
Tested this out a few different times. Essentially running the script as the centos user ensure's that it can be run as non-root. Due to the 744 permissions of the script we execute it via ruby instead of executing the script directly. |
Prior to this commit, we set the cacert, cert, and key but also pass SSL_VERIFY_NONE which negates the need for the former. After this commit, we do not set the cacert, cert, and key so that non-root users can run the script without hitting permissions errors on the keys.
npwalker
force-pushed
the
enable_connecting_to_metrics_endpoint_without_ssl
branch
from
b06f079
to
d14ee6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, we used certificates to connect to the metrics
endpoints despite using SSL_VERIFY_NONE.
After this commit, we forgo the certificates so non-root users can easily
run the script.