Default to no-ssl when PuppetDB on loopback #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, we'd connect to puppetdb over https and not verify certs. This doesn't work prior to 2016.4 because puppetdb has metrics behind a cert whitelist. After this commit, we connect to puppetdb over http if it is running on the same node as the metrics script. This avoids the certificate issue. For PE versions prior to 2016.4. you will not be able to collect metrics on remote puppetdb systems.
npwalker
force-pushed
the
default_to_no_ssl_when_puppetdb_on_loopback
branch
from
f0c5ee0
to
0927de4
Compare
npwalker
changed the title
npwalker
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, we'd connect to puppetdb over https and
not verify certs. This doesn't work prior to 2016.4 because
puppetdb has metrics behind a cert whitelist.
After this commit, we connect to puppetdb over http if it is
running on the same node as the metrics script. This avoids
the certificate issue.
For PE versions prior to 2016.4. you will not be able to collect
metrics on remote puppetdb systems.