Sort hosts before writing them to a file #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hosts might be generated in a non-deterministic order (e.g. from PuppetDB). If that's the case, then the configuration file they're written to will change every run. This ensures that they are always written consistently and avoids spurious change reports.
npwalker
reviewed
Sep 21, 2017
| @@ -22,7 +22,7 @@ | |||
| } | |||
|
|
|||
| $config_hash = { | |||
| 'hosts' => $hosts, | |||
| 'hosts' => $hosts.sort(), | |||
There was a problem hiding this comment.
Does this match the style guide or should it be sort($hosts)?
There was a problem hiding this comment.
I don't see anything in the style guide about it. Happy to change it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hosts might be generated in a non-deterministic order (e.g. from PuppetDB). If that's the case, then the configuration file they're written to will change every run.
This ensures that they are always written consistently and avoids spurious change reports.