Add PuppetDB sync metrics #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sharpie
force-pushed
the
add-puppetdb-ha-metrics
branch
from
a73708d
to
056e722
Compare
|
These metrics are available even when sync is disabled, but are just zeroed out. Figured gathering them by default is easier than trying to auto-detect when sync is turned on. |
|
@Sharpie agreed. As long as they don't cause errors when sync isn't enabled I'm happy to have them included. I'll spin up a box, give this a once over then I'll merge and release. |
npwalker
reviewed
Nov 13, 2017
manifests/puppetdb.pp
Outdated
| @@ -140,10 +140,32 @@ | |||
| 'url' => 'puppetlabs.puppetdb.database:name=PDBWritePool.pool.Wait' }, | |||
| ] | |||
|
|
|||
| $ha_sync_metrics = [ | |||
| { 'name' => 'puppetdb_ha_last-sync-succeeded', | |||
There was a problem hiding this comment.
@Sharpie can you remove puppetdb_ from the front of all of these? That'll make them match the other metrics.
This patch adds metrics from the puppetlabs.puppetdb.ha JMX namespace to the default list of additional metrics collected from PuppetDB for PE 2016.4 and later.
Sharpie
force-pushed
the
add-puppetdb-ha-metrics
branch
from
056e722
to
3116d2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds metrics from the puppetlabs.puppetdb.ha JMX namespace to the
default list of additional metrics collected from PuppetDB for PE 2016.4 and
later.