Compile pcap in compile step
#141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the toolchain was being built in the CMAKE_BINARY_DIR. However, libpcap uses the command, `check_include_file()`, which creates a new CMake project in a temporary folder to test C/C++ features. This causes the OpenWRT SDK to be constantly downloaded multiple times, taking a lot of time. Instead, I've changed the OpenWRT toolchain file to download and extract the SDK next to the toolchain file. This should let the SDK be cached.
Manually setting LIBPCAP_INCLUDE_PATH is not needed, as target_link_libraries(... PCAP::pcap) will automatically include it when needed.
We use `FetchContent_MakeAvailable(libpcap)` to compile libpcap at compile time. Additionally, we only compile `pcap_static`, and nothing else. Since this is a static library, we also don't need to include it in `cmake --install`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
FetchContent_MakeAvailable(libpcap)to compilelibpcapat compile time.Additionally, we only compile
pcap_static, and nothing else.Since this is a static library, we also don't need to include it in
cmake --install.Before Merging
This may cause merge conflicts with #137
After reviewing, switch this branch to https://github.com/nqminds/EDGESec/tree/compile-pcap-in-compile-step-fix-merge-conflict, where I've already fixed the merge conflicts.