ci(publish): fix incorrect Debian data #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not very smart! I never actually tested whether the `.deb`'s created by GitHub were accurate. It looks like by not passing a `data` param, the the data just became a JSON string of the file, so the size looked right, but it was useless data.
mereacre
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not very smart! I never actually tested whether the
.deb's created by GitHub were accurate.It looks like by not passing a
dataparam, the the data just became a JSON string of the file, so the size looked right, but it was useless data.E.g., instead of the
.debfile on the https://github.com/nqminds/edgesec/releases pages being real.debs, they were just strings of"file":{"type":"Buffer","data":[33,60,97,114,99,104,62,10,100,...According to the official GitHub API docs, the actual field name is
data: https://octokit.github.io/rest.js/v18#repos-upload-release-asset