Fully test make_dirs_to_path()
#236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test whether make_dirs_to_path correctly throws an error when:
- an invalid input string is passed (not a string)
- an directory cannot be made
- ENOTDIR (the path contains a non-directory), is the only
error condition we can easily induce. All the other mkdir()
error codes require root Linux access.
Codecov Report
@@ Coverage Diff @@
## main #236 +/- ##
==========================================
+ Coverage 45.52% 45.61% +0.08%
==========================================
Files 107 107
Lines 14940 14951 +11
==========================================
+ Hits 6802 6820 +18
+ Misses 8138 8131 -7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
AshleySetter
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests to add full code-coverage to the function
make_dirs_to_path.Function docs are here, if you want to know what this function is supposed to do https://nqminds.github.io/edgesec/os_8c.html#ab45d38138784ebb93e2eafbc4b20fbf0
@AshleySetter, no pressure if you don't want to review this :) It's not anything urgent, it's just I wanted to add full test coverage for this function since I was the one that added the function.