Add Clang support to edgesec #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C11 officially doesn't supported C++11 raw-strings. GNU does, but this doesn't work on Clang.
Disables GNU/Clang C extension by default on all code, except: - lib/libnetlink (taken from Linux kernel) - lib/libpcap (uses a bunch of BSD-style u_int) - any file that defined `#_GNU_SOURCE` (or similar)
Currently, we aren't passing CC/CXX to our all of our dependencies in `lib/`. This means that CC/CXX are just loaded from the value of CC/CXX in our environment (not any CMake overrides (e.g. in CMakeToolchain file). This commit explicitly passes them.
The ubuntu-20.04 image of GitHub Actions defaults to Clang 11. However, the only version of LLVM that can be easily installed is LLVM 10, which is not compatible with Clang 11.
Codecov Report
@@ Coverage Diff @@
## main #242 +/- ##
==========================================
- Coverage 47.95% 45.77% -2.19%
==========================================
Files 110 107 -3
Lines 16212 16564 +352
==========================================
- Hits 7775 7582 -193
- Misses 8437 8982 +545
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Huh, I've got no idea why adding Clang is changing the code-coverage values by so much (maybe it calculates lines slightly differently?). But Clang seems to be working, so I'll mark this PR as ready to review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds initial basic support for compiling EDGESec with Clang.
Disables GNU/Clang C extensions by default on the edgesec code, except:
#_GNU_SOURCE(or similar)Additionally, I've removed some GNU only features, like
C++11-styled rawstrings.Finally, I've added a CI job for Clang so it'll be tested. It even has code-coverage added!