Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix unknown autoconf os error message #245

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

aloisklink
Copy link
Contributor

Fix the error message that is thrown when the autoconf OS cannot be converted from the CMAKE_HOST_SYSTEM_NAME var.

In CMake, variables always have to be quoted in ${VAR}, using just $VAR is not enough.

Fix the error message that is thrown when the autoconf OS
cannot be converted from the CMAKE_HOST_SYSTEM_NAME var.
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #245 (3146bf5) into main (4393843) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #245   +/-   ##
=======================================
  Coverage   45.61%   45.61%           
=======================================
  Files         107      107           
  Lines       14951    14951           
=======================================
  Hits         6820     6820           
  Misses       8131     8131           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link

@AshleySetter AshleySetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👀

@aloisklink aloisklink merged commit 75dac55 into main Aug 31, 2022
@aloisklink aloisklink deleted the build/fix-autoconf-os-error branch August 31, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants