Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change netinit/in.h #include order #253

Merged
merged 2 commits into from
Sep 5, 2022

Conversation

aloisklink
Copy link
Contributor

On FreeBSD, #include <netinit/in.h> should come before #include <netinit/if_ether.h>, as otherwise struct in_addr won't be defined.

I've modified the .clang-format rules so that after #116 gets merged, this shouldn't cause any issues.

On FreeBSD, `#include <netinit/in.h>` should come before
`#include <netinit/if_ether.h>`, as otherwise `struct in_addr` won't
be defined.
@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #253 (4763da4) into main (1c9a82a) will decrease coverage by 0.69%.
The diff coverage is n/a.

❗ Current head 4763da4 differs from pull request most recent head 97d25d6. Consider uploading reports for the commit 97d25d6 to get more accurate results

@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
- Coverage   48.51%   47.82%   -0.70%     
==========================================
  Files         113      113              
  Lines       17887    19361    +1474     
==========================================
+ Hits         8678     9259     +581     
- Misses       9209    10102     +893     
Impacted Files Coverage Δ
src/utils/nl.c 8.98% <0.00%> (-1.74%) ⬇️
src/utils/os.c 44.37% <0.00%> (-0.92%) ⬇️
src/utils/iface.c 20.00% <0.00%> (-0.54%) ⬇️
src/config.c 0.00% <0.00%> (ø)
src/edgesec.c 0.00% <0.00%> (ø)
src/utils/ifaceu.c 100.00% <0.00%> (ø)
tests/dns/test_mdns_list.c 100.00% <0.00%> (ø)
tests/dns/test_mdns_mapper.c 100.00% <0.00%> (ø)
tests/dhcp/test_dhcp_service.c 100.00% <0.00%> (ø)
tests/dns/test_command_mapper.c 100.00% <0.00%> (ø)
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aloisklink aloisklink merged commit 713fa85 into main Sep 5, 2022
@aloisklink aloisklink deleted the refactor/change-netinit-include-order branch September 5, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants