Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unnecessary middlewares includes #255

Merged
merged 2 commits into from
Sep 5, 2022

Conversation

aloisklink
Copy link
Contributor

Including <netinet/ip.h> is causing issues on FreeBSD.

These includes aren't actually needed, so we might as well get rid of them and speed up compilation slightly.

Including `<netinet/ip.h>` is causing issues on FreeBSD.
These includes aren't actually needed, so we might as well get rid of
them and speed up compilation slightly.
@aloisklink aloisklink added the refactor Refactoring code label Sep 5, 2022
Copy link
Contributor

@mereacre mereacre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great.

@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #255 (fbaee5e) into main (97d25d6) will not change coverage.
The diff coverage is n/a.

❗ Current head fbaee5e differs from pull request most recent head 81a5893. Consider uploading reports for the commit 81a5893 to get more accurate results

@@           Coverage Diff           @@
##             main     #255   +/-   ##
=======================================
  Coverage   48.51%   48.51%           
=======================================
  Files         113      113           
  Lines       17887    17887           
=======================================
  Hits         8678     8678           
  Misses       9209     9209           
Impacted Files Coverage Δ
...apture/middlewares/header_middleware/dns_decoder.c 0.00% <ø> (ø)
...pture/middlewares/header_middleware/mdns_decoder.c 0.00% <ø> (ø)
...ure/middlewares/header_middleware/packet_decoder.c 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aloisklink aloisklink merged commit b206ae5 into main Sep 5, 2022
@aloisklink aloisklink deleted the refactor/remove-unnecessary-middleware-includes branch September 5, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants