refactor(wpabuf): simplify byte swaps #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of glibc 2.19, the following macros are defined in `endian.h`: htobe16(), htole16(), be16toh(), le16toh(), htobe32(), htole32(), be32toh(), le32toh(), htobe64(), htole64(), be64toh(), le64toh() These macros are also defined in FreeBSD, where they are located in the `<sys/endian.h>` file.
These defines are not used anywhere, and are non-standard, and don't appear on FreeBSD. (variables starting with `__` should generally not be used).
Sparse is only used for checking the Linux kernel, we do not use it in this project.
aloisklink
commented
Sep 5, 2022
Codecov Report
@@ Coverage Diff @@
## main #259 +/- ##
=======================================
Coverage 48.51% 48.51%
=======================================
Files 113 113
Lines 17887 17887
=======================================
Hits 8678 8678
Misses 9209 9209
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mereacre
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up the
wpabuf.hfile to improve support for non Linux OSes like FreeBSD.As of glibc 2.19, the following macros are defined in
endian.h:These macros are also defined in FreeBSD, however they are located in the
<sys/endian.h>file.