Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix invalid test variable type #266

Merged
merged 3 commits into from
Sep 9, 2022
Merged

Conversation

aloisklink
Copy link
Contributor

My fault, I accidentally wrote const instead of char, and C implicitly assumed that it was an int pointer.

Maybe it's worth setting -Werror in our code so that all C warnings become errors.

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #266 (7ba1c56) into main (149c1a7) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 7ba1c56 differs from pull request most recent head 826b55f. Consider uploading reports for the commit 826b55f to get more accurate results

@@           Coverage Diff           @@
##             main     #266   +/-   ##
=======================================
  Coverage   48.51%   48.51%           
=======================================
  Files         113      113           
  Lines       17887    17887           
=======================================
  Hits         8678     8678           
  Misses       9209     9209           
Impacted Files Coverage Δ
tests/utils/test_os.c 97.60% <100.00%> (ø)
src/utils/ifaceu.c 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mereacre
Copy link
Contributor

mereacre commented Sep 9, 2022

I added once (a year or so ago) the -Werror. There was a bunch of errors. But we should add it again. I think this time there will be less errors.

@aloisklink aloisklink merged commit 71318fa into main Sep 9, 2022
@aloisklink aloisklink deleted the test/fix-invalid-type branch September 9, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants