Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(middlewares): fix const stype difference #280

Merged
merged 2 commits into from
Sep 20, 2022

Conversation

aloisklink
Copy link
Contributor

ltype was made const in commit 6693778 but some middlewares missed the change.

Fixes: 6693778

ltype was made const in commit 6693778
but some middlewares missed the change.

Fixes: 6693778
@aloisklink aloisklink added the refactor Refactoring code label Sep 19, 2022
@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #280 (5f70e74) into main (12a396b) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head 5f70e74 differs from pull request most recent head 645e4c7. Consider uploading reports for the commit 645e4c7 to get more accurate results

@@            Coverage Diff             @@
##             main     #280      +/-   ##
==========================================
- Coverage   49.04%   49.00%   -0.04%     
==========================================
  Files         116      116              
  Lines       18495    18487       -8     
==========================================
- Hits         9070     9060      -10     
- Misses       9425     9427       +2     
Impacted Files Coverage Δ
...iddlewares/cleaner_middleware/cleaner_middleware.c 14.70% <0.00%> (ø)
...ture/middlewares/pcap_middleware/pcap_middleware.c 23.18% <0.00%> (ø)
tests/utils/test_os.c 97.59% <0.00%> (-0.65%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@mereacre mereacre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@aloisklink aloisklink merged commit f702d76 into main Sep 20, 2022
@aloisklink aloisklink deleted the refactor/fix-missing-const branch September 20, 2022 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants