Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/uk_grey_a #65

Merged
merged 8 commits into from
Jul 17, 2017
Merged

fix/uk_grey_a #65

merged 8 commits into from
Jul 17, 2017

Conversation

daved
Copy link
Collaborator

@daved daved commented Jul 15, 2017

Fixes #64.

This should be merged only if/after #61 is resolved.

@nqthqn
Copy link
Owner

nqthqn commented Jul 17, 2017

Why are you adding the ()'s in?

@nqthqn nqthqn merged commit b68117c into nqthqn:master Jul 17, 2017
@daved
Copy link
Collaborator Author

daved commented Jul 17, 2017

I'm sorry to say that I missed the fact of those changes. They are being added by elm-format. I'll look into this to see if it can be configured or maybe reach some clarity on why it's being done.

@daved daved deleted the fix/uk_grey_a branch July 17, 2017 20:21
@nqthqn
Copy link
Owner

nqthqn commented Jul 17, 2017

oh interesting. what version of elm-format are you using?

@daved
Copy link
Collaborator Author

daved commented Jul 20, 2017

I was running 5.2, and it seems that it was installed manually. I've since installed it using npm and am running the current version (because I love installing ridiculous amounts of dependencies for a simple application, though I may be mistaken about what's going on there).

@nqthqn
Copy link
Owner

nqthqn commented Jul 20, 2017

wow, that's amazing! love that graph. also, scary! look at all those licenses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please banish usage of "grey". This ain't no British colony.
2 participants