Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to laravel 5 #2

Merged
merged 9 commits into from
May 22, 2015
Merged

Port to laravel 5 #2

merged 9 commits into from
May 22, 2015

Conversation

luukholleman
Copy link
Contributor

As the title says, ported to Laravel 5

@luukholleman
Copy link
Contributor Author

I will check if i can fix it

@luukholleman
Copy link
Contributor Author

Fixed the unit tests (except 1), the first unit test always throws this error. But since this error is in Laravel itself i can't do much about it other then making a pull request to Laravel.

@nqxcode
Copy link
Owner

nqxcode commented May 22, 2015

Can you try to update "orchestra/testbench"? In composer.json "orchestra/testbench": "3.0.*"

@luukholleman
Copy link
Contributor Author

I updated and converted some code that no longer worked. I have not much experience with the ioc and facades features so you should check if i'm not doing anything unnecessary.

nqxcode added a commit that referenced this pull request May 22, 2015
@nqxcode nqxcode merged commit 71feac8 into nqxcode:master May 22, 2015
nqxcode added a commit that referenced this pull request Oct 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants