Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup #1

Merged
merged 2 commits into from Oct 9, 2014
Merged

Code cleanup #1

merged 2 commits into from Oct 9, 2014

Conversation

cyril-sf
Copy link
Contributor

@cyril-sf cyril-sf commented Oct 8, 2014

Bringing Ember.js best practices to the application.

@nraynaud
Copy link
Owner

nraynaud commented Oct 8, 2014

Thanks. I think there is a problem with using the operation controller as the current operation. That's what I did in the beginning, but when navigating back to /, the current operation stays inside the controller instead of becoming null.

@cyril-sf
Copy link
Contributor Author

cyril-sf commented Oct 8, 2014

correct, I'll fix that.

@cyril-sf
Copy link
Contributor Author

cyril-sf commented Oct 8, 2014

Problem fixed. I've also fixed an issue that would redirect you when deleting the non current operation.

I feel like they're a better way to deal w/ the current operation, but I don't have enough time ATM.

nraynaud added a commit that referenced this pull request Oct 9, 2014
@nraynaud nraynaud merged commit d33bd7d into nraynaud:gh-pages Oct 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants