Skip to content

Commit

Permalink
Update composer.json to require bcmath
Browse files Browse the repository at this point in the history
I tried running GeoIP2 on a box without the BC Math PHP extension and got the error:

Fatal error: Call to undefined function MaxMind\Db\Reader\bcadd() in /home/vagrant/Akkroo/publish/vendor/maxmind-db/reader/src/MaxMind/Db/Reader/Decoder.php on line 252

The library should depend on ext-bcmath to ensure users do not run in to this problem.

Additionally, the package did not depend on a specific minimum version of PHP.  I assumed the same version as the GeoIP2 package.
  • Loading branch information
nrbrook committed Nov 12, 2013
1 parent 21fd23e commit fbdcbde
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@
"homepage": "http://www.maxmind.com/"
}
],
"require":{
"ext-bcmath":"*",
"php":">=5.3.1"
},
"require-dev": {
"phpunit/phpunit": "3.7.*",
"satooshi/php-coveralls": "dev-master"
Expand Down

0 comments on commit fbdcbde

Please sign in to comment.