Fix #351: Infinite loop using beam source in egs++ #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftessier
approved these changes
Nov 7, 2017
Add an epsilon constant in the energy floating point comparison, to prevent an infinite loop in egs++ applications using a beam shared library source.
blakewalters
approved these changes
Nov 7, 2017
ftessier
force-pushed
the
fix-infinite-loop-egs-chamber
branch
from
b04fde7
to
f7c2d93
Compare
|
Just tweaked the commit message. |
mainegra
approved these changes
Nov 8, 2017
|
Hi Reid, I believe I manually tried to implement that epsilon fix in EGS_2017 but didn't have any success. I haven't looked into this issue much since I haven't been actively working on the TrueBeam model but I can test an input file later on and update you if the issue persists. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a floating point comparison, an infinite loop was possible in egs++ applications using a beam shared library source. This was fixed using the epsilon constant.