Fix #413: limit vacuum step size in magnetic field #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice @ftessier ! |
mainegra
approved these changes
Mar 1, 2018
rtownson
approved these changes
Mar 1, 2018
Adjust the charged particle step routine for transport in vacuum when there is an electromagnetic field (emf). The existing logic failed because the emf step size restriction was not taken into account before the howfar call. Hence the howfar method tracked the particle in a single straight step across the entire vacuum region, causing erroneous region changes and discards. Also check if the particle in fact entered a new region before calling the macro to change the region, since charged particle may take many steps through a vacuum region when there is a field. Remove redundant step size restriction code in the vacuum emf transport macro, now that the field step size restriction in vacuum has been moved ahead of howfar in the electr subroutine.
|
@blakewalters are we good to merge this in its current form? |
blakewalters
approved these changes
Mar 5, 2018
|
Yup @ftessier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the charged particle step routine for transport in vacuum when
there is an electromagnetic field (emf). The existing logic failed
because the emf step size restriction was not taken into account before
the howfar call. Hence the howfar method tracked the particle in a
single straight step across the entire vacuum region, causing erroneous
region changes and discards.