Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix synchdmlc dimension check and medium bugs #455

Merged
merged 2 commits into from Sep 26, 2018
Merged

Conversation

blakewalters
Copy link
Contributor

Fix #441 and #442: Fixes to SYNCHDMLC

  1. Change restriction on width of bottom of support rail (W_railbot) for
    quarter and half target leaves from W_railbot >= W_tip + W_groove to
    W_railbot <= W_tip + W_groove in accordance with TrueBeam
    specs. Accompanying changes to the BEAMnrc and the GUI.
  2. Fix bug in full leaf in which much of the leaf cross section
    was left filled with air instead of actual leaf medium.

@blakewalters
Copy link
Contributor Author

Not quite sure why branch fix-call_vcusource_w_zsrcdum is also included with this, but there you have it.

@deryayucel
Copy link

Sorry but on which file should I change these? I do not want to make a mistake and if you could tell the exact path, I would be glad.

@rtownson rtownson changed the title Fix synchdmlc fixes Fix synchdmlc dimension check and medium bugs Jun 25, 2018
@rtownson rtownson added the bug label Jun 25, 2018
@rtownson
Copy link
Contributor

@deryayucel I recommend waiting until this is at least merged into the develop branch and keeping that up to date using git. If you really want this fix now though, you could use git checkout for this pull request (google how to do that). Or just look in the Files changed tab above to see the changes and full file paths.

@deryayucel
Copy link

@rtownson I am studying on HDMLC and this error forced me to write wrong data to start run. So, if I could do it, it would be better. But do you think it is risky to do it because it is not tested yet? I am not an expert and your opinion matters to me.

@deryayucel
Copy link

@rtownson I checked Files Changed tab but there are many files which are to be changed. All of them are necessary to fix this? Or each one changes something else and I need only one of them?

@rtownson
Copy link
Contributor

@deryayucel I'm not sure these changes fix the error you reported on g+. I submitted that bug as issue #459.

I recommend waiting a couple weeks for these fixes to get merged into develop. If you can't wait, make sure to use git for any checkouts so that you can stay on top of changes.

@blakewalters
Copy link
Contributor Author

Hi @deryayucel and @rtownson: Most of these changes are for the GUI and documentation. If you just want to run with the corrected restriction on W_railbot and fixed FULL leaves, just apply the changes to the SYNCHDMLC_cm.mortran file.

@ojalaj
Copy link

ojalaj commented Jun 28, 2018

Does FULL leaf now allow the geometry of both types of full leaf in Varian HDMLC (#1/target and #60/isocenter)? Even if it would, the point is that since their geometries are different, they can't be included in the input file simultaneously.

@blakewalters
Copy link
Contributor Author

@ojalaj, the FULL leaf is intended to model the FULL type leaf in the VMLC (ie not the HDMLC). There are no designated cross-sections for the OUTBOARD LEAVES #1 and #60. In cases where including these leaves is important, my understanding is that people approximate them using FULL leaves.

@ftessier ftessier force-pushed the fix-synchdmlc_fixes branch 2 times, most recently from 065d7d2 to e0583cb Compare September 20, 2018 18:49
@rtownson
Copy link
Contributor

@blakewalters from what I understand @ojalaj has the designated cross sections for the #1 and #60 outboard leaves. Is it possible that he has different specs? We can address this in a separate issue perhaps.

1. Change restriction on width of bottom of support rail (W_railbot) for
   quarter and half target leaves from W_railbot >= W_tip + W_groove to
   W_railbot <= W_tip + W_groove in accordance with TrueBeam
   specifications. Also change BEAMnrc and the gui accordingly.

2. Fix a bug in full leaves in which much of the leaf cross section was
   left filled with air instead of actual leaf medium.
Input lines for all cross section dimensions must still exist but these
can be filled with blanks, zeroes or arbitrary real numbers for unused
leaf types in the multi-leaf collimator model.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants