Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #489: Allow odd no. of TARGET/ISOCENTER leaves in SYNCHDMLC #514

Merged
merged 1 commit into from Jan 13, 2020

Conversation

blakewalters
Copy link
Contributor

Allows more accurate modeling of Varian HD 120 MLC. Accompanying
changes to GUI and documentation included.

@ojalaj
Copy link

ojalaj commented Apr 23, 2019

@blakewalters first of all I'd like to apologize that testing this PR for issue #489 has taken so long.

I'm able to run a short interactive test simulation with different leaf types defined in .egsinp:
1, 1
13, 2
32, 3
13, 2
1, 1

On screen output everything seems as expected, but why in .egslst I get (I've omitted the accurate span values):
Leaves type Y rangeX coordinates of opening
spanned (cm) NEG (cm) POS
1- 1 1 -5.**** - -4.***** 0.00000 0.00000
2- 59 2 -5.****** - 4.****** 0.00000 0.00000
60- 60 1 4.******* - 5.***** 0.00000 0.00000

  1. According to this there would only be leaves of type 1 and 2 (FULL and TARGET), even if ISOCENTER leaves are defined in .egsinp and correctly shown on run output on screen.
  2. Leaf 2 seems to span to the range of leaf 1, but is this because tongue and groove?

Is all this right? For accurate simulation results we need to wait until the beginning of next week.

@ojalaj
Copy link

ojalaj commented Apr 29, 2019

Simulation results looked reasonable, however accurate simulations and comparison against measurements in the OUTBOARD/FULL leaf region are still not possible, since the SYNCHDMLC CM does not allow the modelling of two different types of OUTBOARD/FULL leaves (#1 and #60).

@blakewalters
Copy link
Contributor Author

Thanks for the testing on this fix, @ojalaj! From the messy output you have in your .egslst file, it looks like your system may be having trouble interpreting some Mortran output statements. In this case, I would trust the screen/.egslog output. Yes, accurate simulation of O60 and O1 is currently not possible with the current FULL leaf design. This may change in the future if we either: a) incorporate more leaf types(!) or b) split this into two CMs, one optimized for simulating the HD120 and one for the 120 MLC.

@ftessier ftessier force-pushed the fix-synchdmlc_allow_odd_no_leaves branch from 5460380 to a52aef8 Compare November 21, 2019 20:18
Allow odd number of TARGET and ISOCENTER leaves in the BEAMnrc SYNCHDMLC
component module, for more accurate modeling of Varian HD 120 multi-leaf
collimator. Update gui and documentation accordingly.
@ftessier ftessier force-pushed the fix-synchdmlc_allow_odd_no_leaves branch from a52aef8 to 17eaefa Compare November 21, 2019 20:50
@ftessier
Copy link
Member

Rebased on develop.

@blakewalters
Copy link
Contributor Author

@ftessier: See my comment on PR #520. There's no reason to hold off on approving/merging this. Another PR is coming in which restrictions in leaf cross-section dimensions are relaxed, but this PR will be incorporated in it.

@ftessier ftessier added this to the Release 2020 milestone Jan 13, 2020
@ftessier ftessier merged commit d39fda3 into develop Jan 13, 2020
@ftessier ftessier deleted the fix-synchdmlc_allow_odd_no_leaves branch January 13, 2020 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants