Fix #497: Fix check on WRAILBOT for TARGET leaves. #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the elements to be automatically changed to upper case for pegsless input. This fixes a crash that occurs when the elements are not found due to the case mismatch.
The number of local regions is 3 times the number of pyramid blocks since the inner and outer air regions are actually the same numbered region.
Previously, in both SYNCVMLC and DYNVMLC, input would fail if, for target leaves: width of bottom of support rail (WRAILBOT) < width of groove (WGROOVE) + width of leaf tip (WTIP) This restriction is incorrect, based on VARIAN's specs for the Millenium and HD 120 MLCs. Moreover, it is inconsistent with the (fixed) check in SYNCHMDMLC. Thus, the check has been changed so that input fails if: WRAILBOT>WGROOVE+WTIP Also, added a check on WTIP for QUARTER/HALF TARGET leaves in SYNCHDMLC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, in both SYNCVMLC and DYNVMLC, input would
fail if, for target leaves:
width of bottom of support rail (WRAILBOT) <
width of groove (WGROOVE) + width of leaf tip (WTIP)
This restriction is incorrect, based on VARIAN's specs for
the Millenium and HD 120 MLCs. Moreover, it is inconsistent
with the (fixed) check in SYNCHMDMLC. Thus, the check has been
changed so that input fails if:
WRAILBOT>WGROOVE+WTIP
Also, added a check on WTIP for QUARTER/HALF TARGET leaves
in SYNCHDMLC.