Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9: Increase array defaults, decrease EPSEMFP #547

Merged
merged 1 commit into from Jan 23, 2020

Conversation

rtownson
Copy link
Contributor

@rtownson rtownson commented Aug 29, 2019

This PR contains a number of suggestions that are up for discussion! There is a tradeoff for compatibility with old systems in moving to larger default array sizes.

  1. Increase a number of array size defaults, since modern systems have considerably more memory on average than they used to.

  2. [Edit: I took this change out, so radiative compton corrections are off by default] Enable radiative compton corrections in all applications. This one is up for debate! From what I understand it requires increasing the stack size, which I have done only for egs_chamber so far in this PR. Should I also increase the stack size for all applications, and do we want this on by default?

  3. Decrease EPSEMFP and EPSGMFP, fixing issue Seg fault with BEAM shared library in DOSXYZnrc with modern gcc versions #9.

These changes are mainly quality-of-life improvements for users who typically had to make the adjustments manually. Thanks to @ojalaj for providing a list of suggestions.

@rtownson rtownson self-assigned this Aug 29, 2019
@rtownson rtownson changed the title Fix #9: Increase array defaults, decrease EPSEMFP and enable radiative corrections Fix #9: Increase array defaults, decrease EPSEMFP and enable radiative Compton corrections Aug 29, 2019
@mainegra
Copy link
Contributor

@rtownson all these changes should definitely be made. I can see that in egsnrc.macros $MXSTACK is only 40. We should definitely increase it although a matter of discussion would be how large. Although memory is readily available these days, we shouldn't be wasteful either.
Regarding the radiative corrections, I agree that right now it is slightly cumbersome to turn them on. If we can prove that having them on by default won't significantly affect simulation efficiency, then we turn them on by default. But if there is a significant penalty in CPU time, given that they have little impact on the results of most cases then keeping them as an option is the way to go. The idea of providing parameter sets for different scenarios comes to mind .... ;-)

@rtownson rtownson added this to the Release 2020 milestone Nov 14, 2019
@blakewalters
Copy link
Contributor

@rtownson: I like these changes to the defaults (max. no. of media = 7! Phwaat?), but I'm with @mainegra on changing the default setting of radc_flag. At what energies and for what simulation geometries is this required?

@rtownson rtownson changed the title Fix #9: Increase array defaults, decrease EPSEMFP and enable radiative Compton corrections Fix #9: Increase array defaults, decrease EPSEMFP Dec 17, 2019
Increase a number of array size defaults, since modern systems have
considerably more memory. Decrease EPSEMFP and EPSGMFP. These changes
are mainly quality-of-life improvements for BEAMnrc and DOSXYZnrc users,
who typically had to make these adjustments manually. Thanks to Jarkko
Ojala for suggesting these changes.
@ftessier ftessier merged commit a91d7e6 into develop Jan 23, 2020
@ftessier ftessier deleted the change-array-defaults branch January 23, 2020 14:22
@ojalaj
Copy link

ojalaj commented Mar 31, 2020

Why not increasing MXSTACK also in egs_chamber?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants