Fix minor bug in DOSRZnrc kerma calculation #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftessier
approved these changes
Aug 12, 2020
|
This Travis CI build failed on egs++ for some reason, and I don't seem to have an option to restart the build. @ftessier are you able to do this, so I don't have to push a new commit to trigger it? |
mainegra
approved these changes
Aug 12, 2020
blakewalters
approved these changes
Aug 17, 2020
|
Compilation fails, reportedly on building the egs++ library; don't know why, and no modification here related to egs++. I am able to build this branch without issue locally (?) |
ftessier
force-pushed
the
fix-dosrz-kerma
branch
from
567a679
to
00bf56b
Compare
|
Relaunched the build and it passed. |
Fix the DOSRZnrc kerma calculation so that sub-threshold fluorescent photons (iarg=33) are included in the kerma. This bug meant that D/K and D/Kcol were not equal to 1 for some cases, up to about a 0.8% difference. This makes the algorithm slightly different from the g app, where only primary photons are considered, because DOSRZnrc includes the kerma from secondary photons.
Improve some output formatting in DOSRZnrc. Also add the IDC (I Double Count) variable to allow the user to exclude kinetic energy released by any bremsstrahlung or 511 keV photons. Some comments are also added to improve code readability, and a never-reached code block was removed.
ftessier
force-pushed
the
fix-dosrz-kerma
branch
from
00bf56b
to
088df7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the DOSRZnrc kerma calculation so that sub-threshold fluorescent photons (
iarg=33) are included in the kerma. This bug meant thatD/KandD/Kcolwere not equal to 1 for some cases, up to about a 0.8% difference. This makes the algorithm slightly different from the g app, where only primary photons are considered, because DOSRZnrc includes the kerma from secondary photons.Add some output formatting improvements to DOSRZnrc. Also add the
IDCor I Double Count variable to allow the user to avoid including k.e. released by any bremsstrahlung or 511 photons. Some comments are also added to improve the readability of the code, and a never-reached code block was removed.Thanks to Dave Rogers and Ernesto for all their work on these improvements!