Fix the dose values in egs++ 3ddose output #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftessier
force-pushed
the
fix-egspp-3ddose-mass
branch
from
7e7e095
to
f98de25
Compare
ftessier
approved these changes
Nov 13, 2020
ftessier
approved these changes
Nov 13, 2020
mainegra
approved these changes
Nov 13, 2020
blakewalters
approved these changes
Nov 16, 2020
ftessier
force-pushed
the
fix-egspp-3ddose-mass
branch
2 times, most recently
from
59fa8f8
to
4aa617d
Compare
Fix the value of dose in 3ddose files generated from egs++ apps using the egs_dose_scoring ausgab object. The dose was not being scaled by the mass of materials, because the getMass function in the ND geometry class was not defined properly for XYZ geometries. This critical bug has existed since the inception of 3ddose file output in egs_dose_scoring (in commit 7e5bf07 on 25 July 2017). In the limited case I tested, the density in every voxel was 1 instead of the proper material density.
Fix a bug where egs_chamber would crash when trying to generate a 3ddose file from an XYZ geometry. This happened because the app pointer was not defined for all of the calculation geometries, since they may skip the geometry initialization that normally occurs. Now the application pointer is set directly in the XYZ geometry.
ftessier
force-pushed
the
fix-egspp-3ddose-mass
branch
from
4aa617d
to
8d0268f
Compare
|
Rebased on develop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the value of dose in 3ddose files generated from egs++ apps using
egs_dose_scoring. The dose was not being scaled by the correct mass/density of materials, because thegetMassfunction in the ND geometry was not functioning properly for XYZ geometries unless they were defined using an egsphant file or density file. In other words, the dose was wrong if the XYZ geometry boundaries were defined using "slabs" or "planes".This is a critical bug in the value of dose reported and has been an issue since the ability to generate 3ddose files was added to
egs_dose_scoring. Any old dose in 3ddose files generated this way should be considered unreliable, due to the undefined value of density, and those simulations should be repeated.Note that the doses reported by
egs_dose_scoringby material, or by region were correct. Only the dose in 3ddose files fromegs_dose_scoringhas this issue. All 3ddose files from DOSXYZnrc are not affected.Big thanks to our reddit user u/5xum for reporting this issue, and @marenaud for determining it was a bug.