Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix phsp output with photon splitting #662

Merged
merged 1 commit into from Mar 26, 2021

Conversation

blakewalters
Copy link
Contributor

@blakewalters blakewalters commented Jan 12, 2021

Photons were not included in the phase space data. This is because $AUSCALL($TRANAUSA) (call to ausgab after particle step) was not included in the $SELECT-PHOTON-MFP macro that handles splitting in dosxyznrc.

Include $AUSCALL($TRANAUSA) (call to ausgab after particle step) in
$SELECT-PHOTON-MFP macro. Previously, when photon splitting was on,
photons were not included in the phase space output data.
@ftessier ftessier force-pushed the fix-phsp_output_with_photon_splitting branch from 4c72488 to 34802d7 Compare March 25, 2021 03:34
@ftessier
Copy link
Member

ftessier commented Mar 25, 2021

Rebased on develop and disentangle from an earlier rebase on the now merged egs-spectrum branch.

@ftessier ftessier added the bug label Mar 25, 2021
@ftessier ftessier added this to the Release 2021 milestone Mar 25, 2021
Copy link
Contributor

@mainegra mainegra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! We had this bug for so long?

@ftessier ftessier merged commit b676308 into develop Mar 26, 2021
@ftessier ftessier deleted the fix-phsp_output_with_photon_splitting branch March 26, 2021 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants