Add checks for gcc version when setting the default c++ standard #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakewalters
approved these changes
Jul 15, 2022
ftessier
approved these changes
Jul 16, 2022
mainegra
approved these changes
Jul 18, 2022
ftessier
force-pushed
the
add-c-std-check
branch
from
2c58c25
to
75781bd
Compare
|
Squashed and reworded commit title to fit. |
ftessier
force-pushed
the
add-c-std-check
branch
2 times, most recently
from
16c25c2
to
75350bf
Compare
|
Added a bit of info in the commit message. |
ftessier
force-pushed
the
add-c-std-check
branch
from
75350bf
to
e3fde66
Compare
Set the c++ standard to c++14 if the g++ version is 5 or greater, otherwise fall back on c++11. Some systems still rely on version 4.8 which only supports up to c++11 features.
ftessier
force-pushed
the
add-c-std-check
branch
from
e3fde66
to
1ac52f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add checks to the configure script, configuration GUI, and egs_view profile before setting
std=c++14as the default c++ standard. If the gcc version is 4 or less, thenstd=c++11is used as the default. This just helps protect against failed installations for users with older gcc versions using the default config settings.Very old versions of gcc might still crash, but the user can easily change the
std=flag as necessary.