This repository has been archived by the owner on Mar 1, 2019. It is now read-only.
Add crate disambiguators #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to distinguish between different versions of a crate or different crate targets such as bin or lib.
This was referenced Oct 23, 2017
nrc
reviewed
Oct 26, 2017
src/lib.rs
Outdated
| #[derive(Debug, Clone, RustcDecodable, RustcEncodable, PartialEq, Eq, Hash)] | ||
| pub struct GlobalCrateId { | ||
| pub name: String, | ||
| pub disambiguator: String, |
There was a problem hiding this comment.
Could you document what the disambiguator looks like please? What are the valid values?
There was a problem hiding this comment.
I couldn't see where Fingerprint was defined. Ideally, you would use FingerPrint here, but that would probably mean pulling it into rls-data which might not be practical. If FingerPrint is defined as (u64, u64) then I'd use that, otherwise u128.
|
Published as 0.12 |
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Nov 2, 2017
Emit crate disambiguators in save-analysis data Needed for rust-dev-tools/rls-analysis#93. Blocked by rust-dev-tools/rls-data#11. (For now, this pulls my branch [rls-data/crate-source](https://github.com/Xanewok/rls-data/tree/crate-source)) This will allow to disambiguate different crates types/versions when indexing resulting save-analysis data (most importantly allow to support bin+lib and different crate versions). r? @nrc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for rust-dev-tools/rls-analysis#93.
This allows to distinguish between different versions of a crate or
different crate targets such as bin or lib.
Will make a PR with changes to librustc_save_analysis generation after a new version with these changes will be published.