Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose data augmentation functions in config file #78

Closed
mpelchat04 opened this issue May 2, 2019 · 1 comment · Fixed by #95
Closed

Expose data augmentation functions in config file #78

mpelchat04 opened this issue May 2, 2019 · 1 comment · Fixed by #95
Labels
enhancement New feature or request good first issue Good for newcomers P2 Medium priority
Milestone

Comments

@mpelchat04
Copy link
Collaborator

mpelchat04 commented May 2, 2019

Data augmentation operations should be exposed in the configuration file. This would allow user ti activate/deactivate them as they need.
We should also include support for external libraries (e.g. Albumentations) to do so, so we don't have to code them all.

@mpelchat04 mpelchat04 added enhancement New feature or request good first issue Good for newcomers P2 Medium priority labels May 2, 2019
@mpelchat04 mpelchat04 added this to the V1.1 milestone Jun 12, 2019
@mpelchat04
Copy link
Collaborator Author

As of today, Albumentations has too many limitations (for our purpose), such as:

  • Most of the transformations can only be done on 3 channel images. Our system is generic anough so someone would be able to use it with >3 channels input images. An example of this limitation is provided in the code here
  • Some transformations assume that input images are uint8. Since we do not want to limit the use of GDL to uint8 images, I'm not sure we should use libraries that makes that assumptions.

Albumentations is not quite suited for our purposes. We'll reconsider the use of this library (or another one) to manage data augmentation later.

In the meantime, we'll still expose our data augmentation operations in the configuration file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers P2 Medium priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant