Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the type of DomainInfoResponse.NoDelegation #4

Merged
merged 1 commit into from
Aug 12, 2020
Merged

fix: the type of DomainInfoResponse.NoDelegation #4

merged 1 commit into from
Aug 12, 2020

Conversation

svenpeter42
Copy link

No description provided.

@ldez
Copy link
Member

ldez commented Aug 12, 2020

Hello, could you give more explanation about this change?

The doc says:

noDelegation | Domain delegation status | boolean | Yes

https://www.inwx.de/en/help/apidoc/f/ch02s08.html#domain.info

@svenpeter42
Copy link
Author

Sure, https://www.inwx.de/en/help/apidoc/f/ch02s08.html#domain.info indicates that NoDelegation should have the type boolean.

For some reason for .de domains this field is always true and when the type is set to string the mapping will fail with

* 'noDelegation' expected type 'string', got unconvertible type 'int64'

@ldez
Copy link
Member

ldez commented Aug 12, 2020

Have you try with a boolean?

could you provide a raw json?

@svenpeter42
Copy link
Author

Yes, with a boolean the result is

* 'noDelegation' expected type 'bool', got unconvertible type 'int64'

What's the easiest way to dump the raw response?

@ldez
Copy link
Member

ldez commented Aug 12, 2020

You can put a fmt.Println like that:

resp, err := s.client.Do(*req)
fmt.Println(resp)

@svenpeter42
Copy link
Author

map[admin:1234567 authCode:REDACTED billing:1 contact:map[admin:map[cc:DE city:SomeCity email:redacted@redacted.tld fax:<nil> id:1234567 name:Some Name org:<nil> pc:12345 protection:1 remarks:<nil> sp:<nil> street:Some Street 123 type:PERSON voice:+49.1234567890] billing:map[cc:DE city:Berlin email:hostmaster@inwx.de fax:+49.3098321290 id:1 name:Hostmaster Of The Day org:InterNetworX Ltd. & Co. KG pc:10969 protection:1 remarks:role account for Hostmaster of the Day sp:<nil> street:Prinzessinnenstr. 30 type:ROLE voice:+49.309832120] registrant:map[cc:DE city:SomeCity email:redacted@redacted.tld fax:<nil> id:1234567 name:Some Name org:<nil> pc:12345 protection:1 remarks:<nil> sp:<nil> street:Some Street 123 type:PERSON voice:+49.1234567890] tech:map[cc:DE city:Berlin email:hostmaster@inwx.de fax:+49.3098321290 id:1 name:Hostmaster Of The Day org:InterNetworX Ltd. & Co. KG pc:10969 protection:1 remarks:role account for Hostmaster of the Day sp:<nil> street:Prinzessinnenstr. 30 type:ROLE voice:+49.309832120]] crDate:2020-08-12 07:36:02 +0000 +0000 domain:redacted.de domain-ace:redacted.de exDate:2021-08-12 07:36:02 +0000 +0000 extData:map[ACCEPT-TRUSTEE-TAC:1 TRUSTEE-CURRENCY:EUR TRUSTEE-PRICE:2.5] noDelegation:1 ns:[ns.ote.inwx.de ns2.ote.inwx.de test.tld] period:1Y reDate:2021-08-11 07:36:02 +0000 +0000 registrant:1234567 registrantVerificationStatus:NONE renewalMode:AUTORENEW roId:54811 status:OK tech:1 transferLock:1 transferMode:DEFAULT upDate:2020-08-12 15:44:18 +0000 +0000 verificationStatus:ACTIVE withPrivacy:<nil>]

@ldez
Copy link
Member

ldez commented Aug 12, 2020

Thank you

@ldez ldez added bug Something isn't working and removed contributor/waiting-for-feedback labels Aug 12, 2020
@ldez ldez changed the title fix the type of DomainInfoResponse.NoDelegation fix: the type of DomainInfoResponse.NoDelegation Aug 12, 2020
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ldez ldez merged commit 176a855 into nrdcg:master Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants